Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove VoxelPrimitive.jitter option #11913

Open
jjhembd opened this issue Mar 30, 2024 · 0 comments
Open

Remove VoxelPrimitive.jitter option #11913

jjhembd opened this issue Mar 30, 2024 · 0 comments

Comments

@jjhembd
Copy link
Contributor

jjhembd commented Mar 30, 2024

The VoxelPrimitive.jitter option applies random shifts to the starting point for voxel ray-marching. This helped blur artifacts at the edges of voxels when using a constant step size.

After #11875, voxels use an optimum step size which fixes the artifacts. This makes the jitter unnecessary, and also effectively ignores the jitter after the first step.

This option should be removed. Since the voxel API is flagged experimental, we may not need a deprecation period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant