Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version check from PR #156 doesn't cover latest v8 #161

Open
hpmachining opened this issue Oct 10, 2024 · 0 comments
Open

version check from PR #156 doesn't cover latest v8 #161

hpmachining opened this issue Oct 10, 2024 · 0 comments

Comments

@hpmachining
Copy link
Contributor

This pull request doesn't cover the latest (major version 13) v8 because the minor version isn't > 6.

Changing if V8_MAJOR_VERSION < 10 || (V8_MAJOR_VERSION >= 12 && V8_MINOR_VERSION > 6)
to if V8_MAJOR_VERSION < 10 || (V8_MAJOR_VERSION >= 12 && V8_MINOR_VERSION > 6) || (V8_MAJOR_VERSION >= 13)
works, but seems like there should be more concise way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant