-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent extraction-and-overwrite of xcframeworks with identical names from GitHub Release assets. #3367
Comments
Currently, lottie-ios 4.4.1 lists two assets on the GitHub release.
I'd wager that Carthage is downloading both And when extracting, there's no ordering that Carthage does. So, one Lottie.xcframework remains at the end (sometimes the 〜 For the side question, we don’t modify what vendors put in their xcframeworks (as they might have instructions. or other special content in there) — we just extract them as-is. that is, assuming the whole xcframework to be extracted as is passes…that is, assuming the whole xcframework to be extracted as is passes …which lottie clearly saw passed for you/your CI. If there was a feature improvement to Carthage to better handle this: (1) I imagine we wouldn't get rid of the overwriting (2) we'd likely land the change here and here. 〜 I might return here with a PR, lemme think on it. In the meantime, lemme see if I can find the old 'roll your own simple Carthage fork on homebrew tutorial' — ah, it's here. |
carthage update
Vending your own 'binary-only framework json and uploaded |
which carthage
: /opt/homebrew/bin/carthagecarthage version
: 0.39.1xcodebuild -version
: Xcode 15.2 Build version 15C500b--no-build
? No--no-use-binaries
? No--use-submodules
? No--cache-builds
? No--new-resolver
? No--use-xcframeworks
? yesCartfile
Actual outcome
Whenever I run carthage update lottie-ios --platform iOS --use-xcframeworks I get one of two different variants (it seems that it is alternating every time I run it.
Once I get:
And then next time I run it I get:
and so on...
I have also tried splitting in two steps:
carthage update "$LIBRARY_NAME" --no-build --use-xcframeworks carthage build "$LIBRARY_NAME" --platform iOS --use-xcframeworks
But that didn't help as well, it still switches between the two each time I run it.
Also, a side question - why does it fetch other variants (eg. such as
macOS
ortvOS
) when I have passed--platform iOS
?Thanks in advance.
The text was updated successfully, but these errors were encountered: