Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

animate Bestow as Static Ability #6811

Open
Hanmac opened this issue Jan 21, 2025 · 4 comments · May be fixed by #6992
Open

animate Bestow as Static Ability #6811

Hanmac opened this issue Jan 21, 2025 · 4 comments · May be fixed by #6992
Assignees

Comments

@Hanmac
Copy link
Contributor

Hanmac commented Jan 21, 2025

Part of #5642

Bestow Effect should use StaticAbility Layers if able

For Layer4, instead of addChangedCardTypes, we need:

  • Add Aura Type + Remove CreatureType + Remove Other Enchantment Types

it needs to effect the Spell before it is put on the Stack, and then Later on the Battlefield

@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 27, 2025

@tool4ever you might look into this too

It might be a bit more tricky for the LKI?
But we could store the BestowEffect inside the Card, so that we can copy it when doing an LKI copy

Also, maybe can you look at this part?

if (sa.isSpell() && sa.isBestow()) {
// already bestowed or in battlefield, no need to check for spell
if (c.isInPlay()) {
return false;
}
// if card is lki and bestowed, then do nothing there, it got already animated
if (!(c.isLKI() && c.isBestowed())) {
if (!c.isLKI()) {
cp = CardCopyService.getLKICopy(c);
}
cp.animateBestow(!cp.isLKI());
}
}

Is it even possible for a BestowSpell to go through checkZoneRestrictions without going through Spell.getAlternateHost first?

I think we should be able to remove that part from SpellAbilityRectrictions

@tool4ever
Copy link
Contributor

Is it even possible for a BestowSpell to go through checkZoneRestrictions without going through Spell.getAlternateHost first?

I'm seeing it called directly in canPlayAI :/

@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 27, 2025

@tool4ever hm Spell.canPlay calls getAlternateHost, while SpellAbilityAi.canPlayAi does not

i need to check how AI does get the Bestow Spell, because GameActionUtils.getAlternativeCosts calls getAlternateHost

i need to debug where the AI needs to be fixed

@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 28, 2025

@tool4ever my main problem there:
if a StaticEffect is created for an LKI object (like to check if it can be cast bestowed)
we need to take care of removing the Effect from the Command Zone again.

unanimateBestow might work for one of these, but we might need to do more generic ones too (like for the Suspect Status)

@Hanmac Hanmac linked a pull request Feb 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants