Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor launch file #34

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Refactor launch file #34

merged 15 commits into from
Nov 20, 2024

Conversation

isaacaka
Copy link
Member

@isaacaka isaacaka commented Sep 18, 2024 •
edited
Loading

First pass on refactoring launch.m. Split the single big main function into multiple sub-functions which are then called by the main function.

  • Move Functions to own individual file in separate folder
  • Write unit tests for each function

Closes #26

dorchard
dorchard reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@dorchard dorchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry only time for partial comments)

@dorchard
Copy link
Member

We decided to build on this PR with the rest of the refactoring and testing. @isaacaka to add a checklist of the items in the PR first post.

@dorchard dorchard added this to the Modularised all MATLAB code milestone Sep 26, 2024
ma595 pushed a commit that referenced this pull request Oct 17, 2024
@gilbertozp
Merge pull request #34 from ARibecaJob/qc_auto_bugfixes
7ea7d31 
qc_auto bugfixes
@dorchard
Copy link
Member

As discussed, for multi-dimensional data we can use the JSON encoding technique as used here:
https://github.com/Cambridge-ICCS/ONEFlux/blob/29-generate-unit-tests-for-cpdbootstrap/oneflux_steps/ustar_cp_refactor_wip/cpdBootstrapUStarTh4Season20100901.m#L147-L150
(since the matlab_engine for Python doesn't let us pass nested data structures)

@isaacaka isaacaka changed the title Refactor launch file [WIP] Refactor launch file Nov 8, 2024
@isaacaka isaacaka linked an issue Nov 8, 2024 that may be closed by this pull request
Modularise launch.m #26
Open
@isaacaka isaacaka requested a review from tztsai November 8, 2024 13:44
@isaacaka isaacaka marked this pull request as ready for review November 8, 2024 13:45
@isaacaka isaacaka requested a review from dorchard November 8, 2024 13:54
dorchard
dorchard reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@dorchard dorchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments but looks good to me. All tests pass for me too.

@dorchard dorchard merged commit 4a4d2ab into ustar_cp_refactor_main Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorchard dorchard dorchard left review comments

@tztsai tztsai tztsai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Modularised all MATLAB code
Development

Successfully merging this pull request may close these issues.

Modularise launch.m
3 participants
@isaacaka @dorchard @tztsai