Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap Torch Scalar #285

Open
jwallwork23 opened this issue Feb 18, 2025 · 1 comment
Open

Wrap Torch Scalar #285

jwallwork23 opened this issue Feb 18, 2025 · 1 comment
Assignees
@jwallwork23
Labels
autograd Tasks towards the online training / automatic differentiation feature enhancement New feature or request

Comments

@jwallwork23
Copy link
Contributor

The Torch C++ API includes a Scalar class, which should streamline handling scalar values in the autograd work.

We should wrap this class as torch_scalar, as well as it's core functionality.
@jwallwork23 jwallwork23 added autograd Tasks towards the online training / automatic differentiation feature enhancement New feature or request labels Feb 18, 2025
@jwallwork23 jwallwork23 self-assigned this Feb 18, 2025
@jwallwork23
Copy link
Contributor Author

I spent a while trying to get this set up but found it was very difficult to deal with the different integer and real types getting cast appropriately. It'd probably be better to define torch_scalar as a rank-1 torch_tensor with a single element, as done in #286.

This was referenced Feb 18, 2025
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwallwork23 jwallwork23

Labels
autograd Tasks towards the online training / automatic differentiation feature enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwallwork23