Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for integer tensors? #255

Open
jwallwork23 opened this issue Jan 27, 2025 · 1 comment
Open

Drop support for integer tensors? #255

jwallwork23 opened this issue Jan 27, 2025 · 1 comment
Labels
question Further information is requested

Comments

@jwallwork23
Copy link
Contributor

As discussed in the meeting today, it's not clear that the current support for integer precision tensors is particularly useful.

I noticed this when working to add unit test fixtures to cover different precisions and also when discovering that the autograd support in Torch doesn't support integer precision.
@jwallwork23 jwallwork23 added the question Further information is requested label Jan 27, 2025
@jatkinson1000
Copy link
Member

Personally I would leave it in, but with a warning/error being raised around autograd for any dtypes that are not supported. My 2¢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwallwork23 @jatkinson1000