Skip to content

Better lighting? #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peque opened this issue Feb 26, 2019 · 2 comments
Open

Better lighting? #7

Peque opened this issue Feb 26, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed question Further information is requested

Comments

@Peque
Copy link
Collaborator

Peque commented Feb 26, 2019

Have a look at three.js examples.

Can we improve the lighting somehow? Changing the default material? Adding shadows?

@Peque Peque added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Feb 26, 2019
@garrlker
Copy link

garrlker commented Oct 2, 2019

I can hit this one as well if you don't mind.

@Peque
Copy link
Collaborator Author

Peque commented Oct 2, 2019

Of course. Keep in mind that this is a subjective thing. I may not like the new lighting enough to merge the changes.

So try to share your results/ideas early and often to discuss them before spending too much work on something that may not be merged. 😉

Ideally, changes could be inspired by some existing, well-known CAD tool, which may already have better looks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants