Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed font-related test error on some platforms #1577

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

jmwright
Copy link
Member

Uses the logo that is embedded in the repo for CadQuery's logo in order to prevent text alignment test failures across platforms.

Closes #1569 and #187

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (5522037) to head (cefc420).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
+ Coverage   94.54%   95.13%   +0.58%     
==========================================
  Files          28       28              
  Lines        5848     7642    +1794     
  Branches     1166     1746     +580     
==========================================
+ Hits         5529     7270    +1741     
- Misses        193      218      +25     
- Partials      126      154      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some cosmetics

tests/test_cadquery.py Outdated Show resolved Hide resolved
tests/test_cadquery.py Outdated Show resolved Hide resolved
@jmwright jmwright merged commit bf47f12 into master May 30, 2024
6 checks passed
@jmwright jmwright deleted the text_alignment branch May 30, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Alignment Test Failure
3 participants