Skip to content

Commit 31e444d

Browse files
Nguyễn Công TúTheWitness
andauthored
fix: [Security] SQL Injection in cacti endpoint (#7146)
Co-authored-by: TheWitness <thewitness@cacti.net>
1 parent 161355b commit 31e444d

3 files changed

Lines changed: 12 additions & 12 deletions

File tree

data_debug.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,8 @@
109109
case 'ajax_hosts':
110110
$sql_where = '';
111111

112-
if (grv('site_id') > 0) {
113-
$sql_where = 'site_id = ' . grv('site_id');
112+
if (gfrv('site_id') > 0) {
113+
$sql_where = 'site_id = ' . gfrv('site_id');
114114
}
115115

116116
get_allowed_ajax_hosts(true, true, $sql_where);
@@ -119,8 +119,8 @@
119119
case 'ajax_hosts_noany':
120120
$sql_where = '';
121121

122-
if (grv('site_id') > 0) {
123-
$sql_where = 'site_id = ' . grv('site_id');
122+
if (gfrv('site_id') > 0) {
123+
$sql_where = 'site_id = ' . gfrv('site_id');
124124
}
125125

126126
get_allowed_ajax_hosts(false, true, $sql_where);

data_sources.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@
8787
case 'ajax_hosts':
8888
$sql_where = '';
8989

90-
if (grv('site_id') > 0) {
91-
$sql_where = 'site_id = ' . grv('site_id');
90+
if (gfrv('site_id') > 0) {
91+
$sql_where = 'site_id = ' . gfrv('site_id');
9292
}
9393

9494
get_allowed_ajax_hosts(true, true, $sql_where);
@@ -97,8 +97,8 @@
9797
case 'ajax_hosts_noany':
9898
$sql_where = '';
9999

100-
if (grv('site_id') > 0) {
101-
$sql_where = 'site_id = ' . grv('site_id');
100+
if (gfrv('site_id') > 0) {
101+
$sql_where = 'site_id = ' . gfrv('site_id');
102102
}
103103

104104
get_allowed_ajax_hosts(false, true, $sql_where);

reports.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,12 @@
9696

9797
$sql_where = '';
9898

99-
if (grv('site_id') > 0) {
100-
$sql_where .= ($sql_where != '' ? ' AND ' : '') . 'h.site_id = ' . grv('site_id');
99+
if (gfrv('site_id') > 0) {
100+
$sql_where .= ($sql_where != '' ? ' AND ' : '') . 'h.site_id = ' . gfrv('site_id');
101101
}
102102

103-
if (grv('host_template_id') > 0) {
104-
$sql_where .= ($sql_where != '' ? ' AND ' : '') . 'h.host_template_id = ' . grv('host_template_id');
103+
if (gfrv('host_template_id') > 0) {
104+
$sql_where .= ($sql_where != '' ? ' AND ' : '') . 'h.host_template_id = ' . gfrv('host_template_id');
105105
}
106106

107107
get_allowed_ajax_hosts(true, true, $sql_where);

0 commit comments

Comments
 (0)