Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.CodeDom.Providers.DotNetCompilerPlatform should use the latest version dependant on the target framework version #59

Open
CZEMacLeod opened this issue Apr 12, 2023 · 1 comment · May be fixed by #62
Open

Microsoft.CodeDom.Providers.DotNetCompilerPlatform should use the latest version dependant on the target framework version #59

CZEMacLeod opened this issue Apr 12, 2023 · 1 comment · May be fixed by #62
Assignees
@CZEMacLeod

Comments

@CZEMacLeod
Copy link
Owner

The package Microsoft.CodeDom.Providers.DotNetCompilerPlatform now has versions 3.11.0 and 4.1.0 released.
The SDK should use the new version where possible.
If the TargetFramework is net472 or higher we can use 4.1.0. For net462 or higher we can use 3.11.0.
If we are trying to target older than net462 (up to net45) we need to keep on the current 3.6.0 version.
@CZEMacLeod CZEMacLeod self-assigned this Apr 12, 2023
@CZEMacLeod
Copy link
Owner Author

This may need to be reworked based on the work in #56 and #54.

  <ItemGroup>
    <_SDKPackageReference Update="Microsoft.CodeDom.Providers.DotNetCompilerPlatform"
                          SDKDefaultVersion="3.11.0"
                          Condition="$([System.Version]::Parse('$(TargetFrameworkVersion.Substring(1))').CompareTo($([System.Version]::Parse('4.6.2')))) &gt;= 0" />
    <_SDKPackageReference Update="Microsoft.CodeDom.Providers.DotNetCompilerPlatform"
                          SDKDefaultVersion="4.1.0"
                          Condition="$([System.Version]::Parse('$(TargetFrameworkVersion.Substring(1))').CompareTo($([System.Version]::Parse('4.7.2')))) &gt;= 0" />
  </ItemGroup>

@CZEMacLeod CZEMacLeod linked a pull request May 29, 2023 that will close this issue
Open
@CZEMacLeod CZEMacLeod linked a pull request May 29, 2023 that will close this issue
Update Microsoft.CodeDom.Providers.DotNetCompilerPlatform - closes #59 #62
Open
@CZEMacLeod CZEMacLeod mentioned this issue Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CZEMacLeod CZEMacLeod

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@CZEMacLeod