Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross compilation broken #98

Open
Duncaen opened this issue Aug 30, 2023 · 2 comments
Open

cross compilation broken #98

Duncaen opened this issue Aug 30, 2023 · 2 comments

Comments

@Duncaen
Copy link

Duncaen commented Aug 30, 2023

The pkgconfig file from the sysroot (/usr/aarch64-linux-musl/usr/lib/pkgconfig/luajit.pc) is correctly located and used when cross compiling, but the resulting path returned by luajit.get_pkgconfig_variable('includedir') does not include the sysroot.

Prior to the commit 2b6df07 this worked since meson constructed the correct include path.

modules/meson.build:35:14: ERROR: Include dir /usr/include/luajit-2.1 does not exist.
@vcunat
Copy link
Member

vcunat commented Sep 3, 2023

Thanks. I suppose you did find some immediate workaround. I'm not sure yet if the longer-term solution will be just revert of this with simple conflicts resolved or something else.

@Duncaen
Copy link
Author

Duncaen commented Jun 2, 2024

e32df41 changed this a bit and now the patch to make cross compilation work just requires to remove the manual luajit.get_pkgconfig_variable('includedir') from the include directories.

--- a/modules/meson.build
+++ b/modules/meson.build
@@ -32,8 +32,7 @@
   ['serve_stale', meson.current_source_dir() / 'serve_stale' / 'test.integr'],
 ]

-mod_inc_dir = include_directories('..', '../contrib',
-  luajit.get_pkgconfig_variable('includedir'))
+mod_inc_dir = include_directories('..', '../contrib')

 mod_deps = [
   contrib_dep,

Not sure if this is an oversight or if this is required for some other platform than linux, I think all modules that require the lua headers now have the include flags through the luajit dependency in mod_deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants