[CBRD-25376] revise error message that may occur when loading ha_node_list and ha_replica_list #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_list and ha_replica_list http://jira.cubrid.org/browse/CBRD-25376 **Description** If incorrect information is used in ha_node_list or ha_replica_list, the following error message is displayed in master.err, and it is hard to find the cause of the error based on this message and fix this error. So, it need to be modified so that the error message is output differently depending on the error type. Please refer to the issue for the changed error message.
joohok
reviewed
May 27, 2024
joohok
approved these changes
May 29, 2024
hornetmj
reviewed
May 29, 2024
hornetmj
approved these changes
May 30, 2024
src/executables/master_heartbeat.c
Outdated
| @@ -4893,7 +4920,6 @@ hb_cluster_initialize (const char *nodes, const char *replicas) | |||
| hb_Cluster->num_nodes); | |||
There was a problem hiding this comment.
It seems that this debugging log information is not useful. How about removing it together? Below is the remaining master error log from my tests.
Time: 05/30/24 11:37:38.472 - ERROR *** file ../src/executables/master_heartbeat.c, line 2779 ERROR CODE = -839, Tran = -1, EID = 2
"ha_node_list is empty.": Unknown system parameter or bad value.
Time: 05/30/24 11:37:38.472 - DEBUG *** file ../src/executables/master_heartbeat.c, line 4920
hb_Cluster->num_nodes is smaller than '1'. (num_nodes=-1).
Time: 05/30/24 11:37:38.472 - DEBUG *** file ../src/executables/master_heartbeat.c, line 5185
hb_cluster_initialize failed. (error=-839).
Time: 05/30/24 11:42:45.109 - ERROR *** file ../src/executables/master_heartbeat.c, line 2779 ERROR CODE = -839, Tran = -1, EID = 2
"cannot find (hornetmj1) in the ha_node_list.": Unknown system parameter or bad value.
Time: 05/30/24 11:42:45.109 - DEBUG *** file ../src/executables/master_heartbeat.c, line 4920
hb_Cluster->num_nodes is smaller than '1'. (num_nodes=-1).
Time: 05/30/24 11:42:45.109 - DEBUG *** file ../src/executables/master_heartbeat.c, line 5185
hb_cluster_initialize failed. (error=-839).
There was a problem hiding this comment.
I got it, I will remove debug log that is "hb_Cluster->num_nodes is smaller than '1'. (num_nodes=-1)"
mhoh3963
added a commit
to mhoh3963/cubrid
that referenced
this pull request
Aug 6, 2024
…_list and ha_replica_list (CUBRID#5231) * [CBRD-25376] revise error message that may occur when loading ha_node_list and ha_replica_list http://jira.cubrid.org/browse/CBRD-25376 **Description** If incorrect information is used in ha_node_list or ha_replica_list, the following error message is displayed in master.err, and it is hard to find the cause of the error based on this message and fix this error. So, it need to be modified so that the error message is output differently depending on the error type. Please refer to the issue for the changed error message.
mhoh3963
added a commit
to mhoh3963/cubrid
that referenced
this pull request
Aug 6, 2024
…_list and ha_replica_list (CUBRID#5231) * [CBRD-25376] revise error message that may occur when loading ha_node_list and ha_replica_list http://jira.cubrid.org/browse/CBRD-25376 **Description** If incorrect information is used in ha_node_list or ha_replica_list, the following error message is displayed in master.err, and it is hard to find the cause of the error based on this message and fix this error. So, it need to be modified so that the error message is output differently depending on the error type. Please refer to the issue for the changed error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25376
Description
If incorrect information is used in ha_node_list or ha_replica_list, the error message("ha_node_list": Unknown system parameter or bad value.) is displayed in master.err, and it is hard to find the cause of the error based on this message and fix this error.
So, it need to be modified so that the error message is output differently depending on the error type.
Please refer to the issue for the changed error message.