[CBRD-25362] bug fix in SP argument type conversion in PL engine #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. time --> datetime, date, timestamp . date --> time (2) support legal type conversions . short --> time, timestamp . int --> time, timestamp . bigint --> time, timestamp . numeric --> timestamp . float --> time, timestamp . double --> time, timestamp (3) check value range when converting a datetime to a timestamp
beyondykk9
reviewed
May 27, 2024
| LocalDateTime.of(9999, 12, 31, 23, 59, 59, 999); | ||
|
|
||
| private static final ZoneOffset TIMEZONE_0 = ZoneOffset.of("Z"); | ||
| // TODO: update the following value along with the server | ||
| private static final ZoneOffset TIMEZONE_SESSION = ZoneOffset.of("+09:00"); |
There was a problem hiding this comment.
It will be reflected default timezone from server in the future (maybe phase 1 or 2)
There was a problem hiding this comment.
Yes. This is a temporary hard-coding
ctshim
approved these changes
May 27, 2024
hgryoo
approved these changes
May 27, 2024
beyondykk9
approved these changes
May 29, 2024
…d java types because the code template uses it
jongmin-won
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-25362
(1) ban illegal type conversions
. time --> datetime, date, timestamp
. date --> time
(2) support legal type conversions
. short --> time, timestamp
. int --> time, timestamp
. bigint --> time, timestamp
. numeric --> timestamp
. float --> time, timestamp
. double --> time, timestamp
(3) check value range when converting a datetime to a timestamp