Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking in models.py #126

Open
2 tasks
dilawar opened this issue Jul 24, 2021 · 0 comments
Open
2 tasks

Type checking in models.py #126

dilawar opened this issue Jul 24, 2021 · 0 comments

Comments

@dilawar
Copy link

dilawar commented Jul 24, 2021

  • np.array members are called on int

S = S.clip(0)

S, I and D are int here: clip wont work. Are these self.S etc that are list[int]?

Similary .copy(), .astype(), .clip() is called on int in a few places.

  • int is being treated as Sequence

shape = (sims, bins) = S0.shape

doesn't make sense since S0 is int in argument.

dilawar pushed a commit to dilawar/epimargin that referenced this issue Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant