Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model : SIR has missing units #124

Open
dilawar opened this issue Jul 24, 2021 · 0 comments
Open

model : SIR has missing units #124

dilawar opened this issue Jul 24, 2021 · 0 comments

Comments

@dilawar
Copy link

dilawar commented Jul 24, 2021 •
edited
Loading

epimargin/epimargin/plots.py

Line 304 in 7170f5f

def plot_SIRD(model: SIR, layout = (1, 4)) -> PlotDevice:

If model is a SIR type then it is missing .units (this function expects .units). Is it NetworkedSIR or other specialization (I don't see inheritance though)? If it is then t = has issues because model.Rt doesn't exist. I guess t= can be moved inside the loop?
Also in the for loop in this function, model is reused that may case mypy typer checker to fail (not essential).

Similarly plot_curves probably expects models: Sequence[NetworkedSIR] rather than model: Sequence[SIR]?

openjournals/joss-reviews#3464
dilawar pushed a commit to dilawar/epimargin that referenced this issue Jul 24, 2021
potential fix: COVID-IWG#124
86682bb
dilawar pushed a commit to dilawar/epimargin that referenced this issue Jul 24, 2021
potential fix: COVID-IWG#124 and potential fix: COVID-IWG#125
983c3ba
dilawar pushed a commit to dilawar/epimargin that referenced this issue Jul 24, 2021
few minor tweaks to keep mypy happy in plots.py file
2a2443f 
Related:

- COVID-IWG#124
- COVID-IWG#123
@satejsoman satejsoman mentioned this issue Aug 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dilawar