Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST_NO missing for a suggestion in tests_nameservices #1280

Closed
SixK opened this issue Mar 23, 2022 · 1 comment · Fixed by #1395
Closed

TEST_NO missing for a suggestion in tests_nameservices #1280

SixK opened this issue Mar 23, 2022 · 1 comment · Fixed by #1395
Assignees

Comments

@SixK
Copy link

SixK commented Mar 23, 2022

Describe the bug
All ReportSuggestion lines have ${TEST_NO} as first argument, except one in tests_nameservices file

The following command shoud return nothing, but return 1 line :
grep -r ReportSuggestion | grep tests | grep -v TEST_NO
tests_nameservices: ReportSuggestion "Disable the usage of NIS/NIS+ and use an alternative like LDAP or Kerberos instead"

Please change line to:
ReportSuggestion "${TEST_NO}" "Disable the usage of NIS/NIS+ and use an alternative like LDAP or Kerberos instead"

Regards,
SixK

@mboelen
Copy link
Member

mboelen commented Mar 23, 2022

Good catch. Want to create a pull request for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants