Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate Gen Basis Matrices #1737

Open
jeremylt opened this issue Jan 30, 2025 · 0 comments · May be fixed by #1739
Open

De-duplicate Gen Basis Matrices #1737

jeremylt opened this issue Jan 30, 2025 · 0 comments · May be fixed by #1739

Comments

@jeremylt
Copy link
Member

Follow-up on #1735

We've got the code for preventing duplication of the restriction operations. This same code can be modified to make sure we don't LoadMatrix the same matrix multiple times. This duplication isn't a big deal with tensor bases, but its important for non-tensor bases. Currently, we have 2x duplication of those mats for the BPs - once for the input field and once for the output field with the exact same basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant