Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen Tensor/NonTensor Mixed #1736

Open
jeremylt opened this issue Jan 30, 2025 · 0 comments
Open

Gen Tensor/NonTensor Mixed #1736

jeremylt opened this issue Jan 30, 2025 · 0 comments

Comments

@jeremylt
Copy link
Member

Follow-up on #1735

The current parallelization strategy for non-tensor and tensor bases means that we cannot currently mix them in gen backends.

The fix isn't too bad - we need to make a version of the tensor operator that assumes t_id_y == 1 by decomposing t_id_x = a + b * P_1D. Same tensor contractions in 2D, but just different mapping to threads. For 3D we'll need a new template that extends the 2D approach in the natural way instead of using 2D slabs.

Its straightforward, but I wanted to do this separately so the PR for #1735 doesn't get too big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant