Skip to content

Commit 41659e3

Browse files
committed
Revise developer instructions
1 parent 6285b1c commit 41659e3

File tree

5 files changed

+63
-17
lines changed

5 files changed

+63
-17
lines changed

.cspell.json

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,31 +25,36 @@
2525
"Battlecharged",
2626
"codemirror",
2727
"delim",
28-
"excepthook",
28+
"Descrip",
2929
"Erdania",
30+
"excepthook",
31+
"isort",
3032
"kernelspec",
3133
"levelname",
3234
"manip",
35+
"markdownlint",
3336
"nbconvert",
3437
"nbformat",
3538
"premade",
3639
"Premade",
3740
"premades",
41+
"Prereq",
42+
"Prereqs",
3843
"pydot",
3944
"reflavoring",
4045
"remixable",
4146
"roleplay",
4247
"Roleplay",
4348
"ruleset",
49+
"Scrying",
4450
"Shortbow",
4551
"Shortsword",
46-
"Thadius",
4752
"TTRPG",
4853
"TTRPGs",
49-
"workshopped",
5054
"Vuln",
5155
"Vulny",
52-
"Vulnys"
56+
"Vulnys",
57+
"workshopped"
5358
],
5459
// flagWords - list of words to be always considered incorrect
5560
// This is useful for offensive words and common spelling errors.

.markdownlint.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ MD025: false # permit adjacent headings
99
MD026: false # permit trailing punctuation in headings
1010
MD033: # HTML elements allowed
1111
allowed_elements:
12-
- "br"
12+
- "img"
1313
MD034: false # Bare URLs OK
1414
MD036: false # permit emphasis as heading

README.md

Lines changed: 51 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,30 +17,70 @@ about how to play.
1717

1818
## Developers
1919

20-
### Markdown
20+
### Getting Started
2121

22-
While not strictly enforced, we ask that you observe
23-
[Markdown Linting](https://github.com/DavidAnson/markdownlint). The following can be
24-
added to a vscode settings file. The [Rewrap](https://github.com/stkb/Rewrap/) extension
25-
supports wrapping to 88 characters.
22+
1. **Issues**. Proposing changes is as easy as [opening an issue](https://github.com/DeckofAdventures/TheGame/issues/new/choose).
23+
2. **Edits**. The development team would welcome a PR that made direct edits to existing
24+
docs. Be aware that many lists (e.g., Powers, Bestiary, etc.) are managed as `yaml`
25+
files that can be edited directly and then transformed before or after a PR.
26+
3. **Running Code**. The `environment.yaml` file specifies a
27+
[Conda](https://docs.conda.io/en/latest/) environment that will allow you to run all
28+
code and generate documentation. `mkdocs` will allow you to see what the docs site
29+
looks like before commiting by visiting `localhost:8000`
30+
31+
```console
32+
conda env create -f environment.yaml # Generate conda environment
33+
conda activate dofa # Activate the environment
34+
python automation/main.py # Generate md docs
35+
bash docs/docs.sh serve # Generate md docs and deploy site
36+
```
37+
38+
### VS Code Extensions
39+
40+
The following VS Code extensions have been used to support development...
41+
42+
1. Markdown Lint: Establishes uniformity across docs
43+
- [Extension](https://marketplace.visualstudio.com/items?itemName=DavidAnson.vscode-markdownlint)
44+
- [GitHub](https://github.com/DavidAnson/markdownlint).
45+
- Config: `.markdownlint.yaml`
46+
2. Rewrap: Supports hard wrapping docs to 88 characters, which makes facilitates PR
47+
review. The default keyboard shortcut is `alt+q` or `option+q`.
48+
- [Extension](https://marketplace.visualstudio.com/items?itemName=stkb.rewrap)
49+
- [GitHub](https://github.com/stkb/Rewrap/)
50+
3. CSpell: Allows custom dictionaries on spell-check.
51+
- [Extension](https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker)
52+
- [GithHub](https://github.com/streetsidesoftware/vscode-spell-checker)
53+
- Config: `.cspell.json`
54+
4. Black Formatter: Supports code uniformity.
55+
- [Extension](https://marketplace.visualstudio.com/items?itemName=ms-python.black-formatter)
56+
- [GitHub](https://github.com/microsoft/vscode-black-formatter)
57+
58+
The following items may also be helpful in a `.vscode/settings.json` file
2659

2760
```json
2861
{
2962
"[markdown]" : {
3063
"editor.rulers": [88],
3164
"editor.formatOnPaste": true,
32-
"editor.formatOnSave": true,
33-
// https://github.com/stkb/Rewrap/
34-
// Toggle via command prompt per file
35-
// Default paragraph rewrap key: alt+q or option+q
65+
"editor.formatOnSave": false,
3666
"rewrap.autoWrap.enabled": true,
3767
"rewrap.wrappingColumn": 88
3868
},
39-
// https://github.com/DavidAnson/markdownlint
4069
"editor.codeActionsOnSave": {
4170
"source.fixAll.markdownlint":true
4271
},
43-
"markdownlint.focusMode": 5, // ignore issues around the cursor
72+
"python.analysis.autoImportCompletions": false,
73+
"python.formatting.provider": "black",
74+
"python.defaultInterpreterPath": "/YOUR/LOCAL/PATH",
75+
"python.formatting.blackArgs": [
76+
"--line-length=88",
77+
"--exclude='.env'"
78+
],
79+
"[python]": {
80+
"editor.formatOnSave": true,
81+
"editor.defaultFormatter": "ms-python.python"
82+
},
83+
"notebook.formatOnSave.enabled":true,
4484
}
4585
```
4686

docs/src/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ hide:
33
- feedback
44
---
55

6-
# Welcome to Deck of Adventures, The Game!
6+
# Welcome to Deck of Adventures, The Game
77

88
<img src="stylesheets/Logo_Transparent.png" alt="Logo" width="200"/>
99

environment.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,4 @@ dependencies:
99
- pip
1010
- pip:
1111
- -r file:requirements.txt
12+
- -e .

0 commit comments

Comments
 (0)