Enable creation of nodes from dictionary #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brili please check if that is along the lines of what you had in mind.
Tests are passing on my end.
(I also see that @izaim added a branch for CI tests here, probably coming soon.)
I am skipping
CriptNode.final_update
if the node is notinitialized
.I added a test that uses Materials from a search, which get successfully converted to nodes.
We may want to try other types of classes too.
I am open to making the new private functions.
CriptNode._from_dict
CriptNode._cls_from_dict
public. I would like to know what you think for the design and user experience.
@Ardi028 for visibility.