Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: replace all Union[something, None] with Optional[something] instead #152

Open
nh916 opened this issue Jun 8, 2023 · 0 comments
Open

Upgrade: replace all Union[something, None] with Optional[something] instead #152

nh916 opened this issue Jun 8, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@nh916
Copy link
Contributor

nh916 commented Jun 8, 2023 •
edited
Loading

Description

In a bunch of places I used Union[something, None] which is technically correct but Union is supposed to be used for if it could be either this or that, and not this or optional.

Switching it from Union[something, None] to Optional[something] would be more correct
@nh916 nh916 changed the title Upgrade: replace all Union[something, None Upgrade: replace all Union[something, None] with Optional[something] instead Jun 8, 2023
@nh916 nh916 added the good first issue Good for newcomers label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nh916