Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade sqlalchemy to 1.4 #182

Closed
wants to merge 2 commits into from
Closed

feat: upgrade sqlalchemy to 1.4 #182

wants to merge 2 commits into from

Conversation

kylejb
Copy link

@kylejb kylejb commented Jan 2, 2022

Closes #181


Summary

  • Update SQLAlchemy to v1.4.
  • Update SQLAlchemy-Utils to 0.38.2 (supports SQLAlchemy v1.4).
  • Add asyncpg to dependencies; this is a required driver to work with SQLAlchemy's create_async_driver.
  • Update instantiation of session engine with SQLAlchemy's create_async_driver.
  • Update tests to connect to database asynchronously.

Questions

  1. Should we explicitly add greenlet as another dependency? It doesn't seem to cause issues in Docker, but may be required in some local contexts.
  2. Would you like me to fix tests to work with the synchronous drivers or update all tests to work with asyncio (i.e., ORM's new async driver and asyncpg)?

kylejb and others added 2 commits January 2, 2022 14:09
* feat: upgrade sqlalchemy-utils to 0.38.2

* feat: update alembic.ini to support async migrations

* WIP: update tests with asyncio engine
@kylejb
Copy link
Author

kylejb commented Feb 4, 2023

Closing due to inactivity.

@kylejb kylejb closed this Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any plans to upgrade to SQLAlchemy 1.4+
1 participant