You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First of all, thank you for this library and all other awesome work that you do!
I was browsing through sources of this crate to get a better understanding of how everything works and found something odd in reader.rs:789.
implReader<Reader<File>>{
I've spent quite some time trying to understand the intent here, but luckily we have Cargo so I ended up cloning the project and experimenting with it. It turns out that the project will build and test pass if we remove inner Reader or replace it with any other type.
This silliness also works:
implReader<Reader<Reader<Reader<File>>>>{
implReader<Vec<File>>{
So I'm assuming that this is just a typo that curiously slipped through the type checker.
I think it should be fixed to be just impl Reader<File> { ... to not scare Rust newbies like myself.
The text was updated successfully, but these errors were encountered:
Hello Andrew!
First of all, thank you for this library and all other awesome work that you do!
I was browsing through sources of this crate to get a better understanding of how everything works and found something odd in reader.rs:789.
I've spent quite some time trying to understand the intent here, but luckily we have Cargo so I ended up cloning the project and experimenting with it. It turns out that the project will build and test pass if we remove inner
Reader
or replace it with any other type.This silliness also works:
So I'm assuming that this is just a typo that curiously slipped through the type checker.
I think it should be fixed to be just
impl Reader<File> { ...
to not scare Rust newbies like myself.The text was updated successfully, but these errors were encountered: