-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key option is not correctly forwarded in builder.getAll #2973
Comments
@IqualityHerre thanks for the detailed report! We will let you know when we ship a fix for this one |
Permalink to code: builder/packages/core/src/builder.class.ts Line 2739 in 4d38bc1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Here: https://github.com/BuilderIO/builder/blob/main/packages/core/src/builder.class.ts#L2736
The or operator
||
binds stronger than the tertiary operator?
.The code seems to intended as:
However as
||
binds stronger it's actuallyMeaning that the
options.key
value is always ignored. Inside the browser the modelName followed by a hash is passed and outside the browser undefined is always passed (unless a key option is provided in which case it's still ignored but the modelName followed by a hash is used).To Reproduce
Steps to reproduce the behavior:
builder.getAll
and provide akey
option.key
value is not used and the modelname followed by a hash is used instead.Expected behavior
If
options.key
is provided then it's used.This explicitly causes issues when doing multiple requests on the same modelName where requests after the first return promises that never fulfill.
The text was updated successfully, but these errors were encountered: