-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class for all strings constant parameters #2415
Comments
last attribute of rejectValue method isn't @nullable use method with only 2 args. in Erros.class |
create feature centralise-string-const |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Branch : develop-6.0.x
It's better to avoid mistakes to use final Class to declare all Strings constants like attributes, errors or paths.
We can create a class in package org.broadleafcommerce.common for all modules for BroadLeafCommerce Attributes :
Branch : develop-6.0.x
Feature : centralise-string-const
Package : org.broadleafcommerce.common
Class name : BLCA
Attributes starting with ATTRIBUTE_
Errors starting with ERROR_
Paths starting with PATH_
BLCA in package org.broadleafcommerce.common
![image](https://user-images.githubusercontent.com/20228762/94337785-73010480-ffed-11ea-9a7a-9f495ac3adab.png)
and use like this in org.broadleafcommerce.profile.web.controller.validator.CustomerPhoneValidator Class
CustomerPhoneValidator in package org.broadleafcommerce.profile.web.controller.validator
![image](https://user-images.githubusercontent.com/20228762/94337806-8f04a600-ffed-11ea-950f-f6a6597e56f2.png)
I can implementing this basic feature for my first contribution to your project.
I'm waiting for your opinion
I thing i'ts better to separate Attributes, Errors and Paths in separates classes like:
The text was updated successfully, but these errors were encountered: