Why are certain talent stacks associated with upgrade events?

[yretenai]

My quest to find quest progress data continues, I ended up finding Nova's snipe master stacks in NNet.Replay.Tracker.SUpgradeEvent but not any other talent. So I started looking at the game data to see if there's any reason why this may be.

Nova is one of a few (I think only Gall has a similar statement) heroes that has a <CUpgrade> tag, causing the data to be carried over to the replay SUpgradeEvent packet. Other talent/trait quests use Tokens as defined in Galaxy scripts via UnitSetTokenCount and UnitCreateEffectUnit, which are seemingly missing from replay data. Why don't all quests use CUpgrade, or how/why isn't token data in the replay?

Chromie has "ChromieSandBlastPastAndFutureMeQuestToken" and "ChromieSandBlastQuestToken", neither of those strings are present in the replay.

[barrett777]

+1 for including more talent quest completion data in the replay file

FYI here are the talent upgrade events I've found so far:

NovaSnipeMasterDamageUpgrade
GallTalentDarkDescentUpgrade
RegenMasterStacks
MarksmanStacks
WitchDoctorPlagueofToadsPandemicTalentCompletion

[yretenai]

WitchDoctorPlagueofToadsPandemicTalentCompletion

Strange that it has that but not for individual voodoo stacks. I wonder if I can find any others in the game's XML files.

[yretenai]

Found two more in the game data but they're not related to quests but just talents in general, which further puzzles me as to why quest stacks are lumped in with this.

NecromancerEchoesOfDeathTalentUpgrade, Xul's Echoes of Death talent
TracerJumperButtonSwap, Tracer's Jumper talent.