Manokwari search : the result item with shortest title should be prioritized

[herpiko]

Example : the user typed termi which means he/she want to open Terminal, but Root Terminal showed up as the first item in result. Terminal should be on the top.

[Double-A-92]

I'm working on it with a friend. However we ran into some problems... Our new sorting algorithm seems to work, but it's sorting the package name instead of the title of the application. Is there some catch?

[alunux]

@Double-A-92 You don't need to touch package stuffs. You just need to parse *.desktop files in /usr/share/applications and get the title of the application from Name section. Btw, you can play withGenericName, or Comment too, it will make searching more interesting.

[Double-A-92]

What do you mean by package stuff? I made changes in manokwari/system/js/search.js .
And where would I put the parsing code? there are no *.desktop files in this repo...

[herpiko]

@Double-A-92 Could you push your code to some branch? I'll take a look.

[Double-A-92]

@herpiko I have it in my fork here: https://github.com/Double-A-92/manokwari/blob/master/system/js/search.js Thanks :)

[Double-A-92]

@herpiko I just pull requested it into your dev branch. It still doesn't work as supposed, But at least it doesnt break and the code is a bit more cleaner.

[herpiko]

@Double-A-92 Hi!

I've reviewed and test your code. Even if it doesn't solve this issue, it's nice. Thank you for your contribution! I've merged the PR to specific branch and found it's hard to squashing/grouping your commits without removing the commiter metadata.

Contributors are supposed to squash their commits before PR. I want to make sure all the commit messages in the master branch are clean and explicit. Could you squash your commits and re-PR again (to master instead of dev branch)?

Or, do you want me to recommit all of your changes and let your name (committer metadata) lost (I'll mention your github username instead in the commit message)?

[herpiko]

@Double-A-92 Your #97 has been merged. Thank you!

I'll let this issue remains open.