Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More thorough testing mode #1215

Open
1 of 6 tasks
PeterSurda opened this issue Apr 9, 2018 · 4 comments
Open
1 of 6 tasks

More thorough testing mode #1215

PeterSurda opened this issue Apr 9, 2018 · 4 comments
Labels
developers The issue is relevant mainly for developers rather than users enhancement New feature test
Milestone

Comments

@PeterSurda
Copy link
Member

PeterSurda commented Apr 9, 2018

Instead of just sleeping for 30 seconds before shutdown, the testing mode should:

  • create a new random address
  • send a message from that address to a testing address (TBD)
  • wait until the ACK arrives (UISignaller queue can be used for this)
  • show synchronisation progress and connection status every 10 seconds
  • wait until synchronisation finishes
  • change test mode description to explain it's for developers rather than end users
@PeterSurda PeterSurda added the developers The issue is relevant mainly for developers rather than users label Apr 9, 2018
@g1itch
Copy link
Collaborator

g1itch commented Apr 9, 2018

Agreed. As I wrote before, I'm in process of transforming that 30 sec timeout into 30 sec since last API command (after synchronization finish - with your elaboration). Basic testing I've planned to implement trough API commands (address creation, message sending). That's why I'm doing cleanup of the api module.

@PeterSurda
Copy link
Member Author

I think there should be a separate API test.

@g1itch
Copy link
Collaborator

g1itch commented Apr 10, 2018

With API at least I understand how to implement such tests. You can check the first results in my branch test-mode. Otherwise the tests should apparently be asynchronous and will probably require sophisticated testing lib...

@PeterSurda
Copy link
Member Author

PeterSurda commented Apr 10, 2018

You can run the tests in the main thread (which normally runs the GUI and in the daemon mode does nothing). As for getting feedback, you just do a non-blocking get on the relevant queues (e.g. the ui signaller queue and address generator return queue) with a small timeout. It shouldn't be very difficult.

MahendraNG added a commit to MahendraNG/PyBitmessage that referenced this issue Apr 13, 2018
MahendraNG added a commit to MahendraNG/PyBitmessage that referenced this issue Apr 13, 2018
@PeterSurda PeterSurda added this to In progress in Code quality Apr 25, 2018
@PeterSurda PeterSurda added this to the v0.7.0 milestone Aug 27, 2020
@PeterSurda PeterSurda added this to To do in Build system via automation Aug 27, 2020
@g1itch g1itch added enhancement New feature test labels Mar 2, 2021
@g1itch g1itch pinned this issue Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developers The issue is relevant mainly for developers rather than users enhancement New feature test
Projects
Build system
  
To do
Code quality
  
In progress
Development

No branches or pull requests

3 participants