-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match state as well on the /members/mapsearch/
endpoint.
#126
Comments
Can i take up this issue ?? |
Sure, go ahead! |
I am facing a issue that when I create an Alumni profile, it does not show up on at So as to check the search functionality i need to create some alumni profiles ,am I missing anything as I am new to django . |
@Ritish134 You would need to first verify the profiles you've created by logging in as Admin, then only they'll appear on the |
Also, if you're creating the users using the Registration Form on the |
Yes ,did that but after verifying the profile it gives an error |
@Ritish134 It's giving error because you've saved incorrect values in the If you look closely at the error above, there's a regex there: |
Ooh yes got it thanks 😅 |
How is it ? @garg3133 |
@Ritish134 This isn't what I was talking about (and I should have been more clear on the steps to reproduce the issue). This issue is related to the
As for the changes you've done till now, while it looks good, we don't really need a 'state' input on the page to search for alumni. But while you're at it, maybe you can fix another issue on that page related to responsiveness. This is how the page looks on mobile screens: On small screens, each input should be in separate rows and wide enough for users to interact with them. Maybe you can fix this in the current PR (as you are already working on that page) and the other issue in a separate PR? |
Let me know if you face any further issues here. I've filed a separate issue for the responsiveness thing: #133. |
On the above-mentioned endpoint, currently we only match the city (we get the 'search' query as
city, state, country
). This leads to discrepancies in the profiles shown on the result page because two cities at different places can have the same name.So, along with 'city', we should filter on the basis of the 'state' as well.
Steps to reproduce the issue
localhost:8000/geolocation
page, zoom in to the city you just created the profile with at any one of the states, and click on it to go to the/members/mapseach
page.The text was updated successfully, but these errors were encountered: