-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimal swap routes #3885
Comments
@mrgrauel: Thanks for opening an issue, it is currently awaiting triage. The triage/accepted label can be added by foundation members by writing /triage accepted in a comment. DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@mrgrauel: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this! You can add area labels by leaving a DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@mrgrauel: Thanks for opening an issue, an appropriate priority will be added soon. The priority labels can be added by foundation members by writing /priority [type] in a comment. DetailsI am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
<!-- Thanks for sending a pull request! --> #### What this PR does / why we need it: Initially, the behavior is always to return the highest yield when doing swaps. We have updated it to use direct path first (if available) before considering other options. Even if direct path is more expensive. This will revert it to its original behavior as some pairs are cheaper via composite swaps. (e.g, DFI -> DUSD). Will fix this issue - BirthdayResearch/defichain-wallet#3885 #### Which issue(s) does this PR fixes?: <!-- (Optional) Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes # #### Additional comments?:
What would you like to be added:
Swaps always use the optimal route with the best outcome for the enduser
Why is this needed:
Users don't understand pool ratios and shouldn't have to, but at the moment users who want to buy dUSD with DFI always use the dUSD-DFI pool even with a composite swap. The routing DFI - dUSDC/T - dUSD would be much better at the moment (10-20% difference) for them. I know it would add sell pressure on DFI, but it's unfair for the casual users.
Users complain on social media, because it's not as easy to understand.
The text was updated successfully, but these errors were encountered: