Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Generator doesn't create a default user for the API #13

Open
a-barbieri opened this issue Nov 27, 2018 · 3 comments
Open

Generator doesn't create a default user for the API #13

a-barbieri opened this issue Nov 27, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@a-barbieri
Copy link
Contributor

Issue

Generator doesn't create a default user for the API, but doesn't warn you need to have at least one.

Binda API: v0.0.1.alpha.1
Binda: 0.1.11
Ruby on Rails: 5.2

@a-barbieri a-barbieri added the enhancement New feature or request label Nov 27, 2018
@Marchino
Copy link
Contributor

The Generator doesn't create an API User because it doesn't know what contents shall be whitelisted.
We could:
a. just warn at install time that you need to create an API User in order to user the API
b. Create an API User that can see every Structure available at that time

What do you think?

@Marchino
Copy link
Contributor

I'm sorry Alessandro but I don't think this solution is ok...
Api user is created, but can't see anything through the API.
Another thing that smells bad is the class method in the model. That should't ben there.
We should have some sort of installer like the one we have for Binda Shopify.

@a-barbieri
Copy link
Contributor Author

a-barbieri commented Nov 27, 2018

Sorry, I've just seen both messages. Happy to amend anything where needed.

Api user is created, but can't see anything through the API.

You are right. I haven't thought about that.

b. Create an API User that can see every Structure available at that time

Shall we do that?

class method in the model

That's here to make it easier to test, but happy to amend it. When you say "some sort of installer like the one we have for Binda Shopify" do you mean this lines?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants