Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate styling to css #77

Open
jvmanke opened this issue Sep 3, 2019 · 0 comments
Open

Delegate styling to css #77

jvmanke opened this issue Sep 3, 2019 · 0 comments

Comments

@jvmanke
Copy link

jvmanke commented Sep 3, 2019

Currently it is not possible to change axis stroke color through css.

In the parcoords.css such css property is set to a default, but it has no effect because these properties are set with d3s .style() function, having priority over css.

The values set through javascript are the same as the ones on the css sheet leading me to believe they are set as defaults.

Some of these properties are merely stylistic in nature, which could be useful if configurable (through css specialy), however some of them could be tied to the shape of the plot.

I could find some properties that could outsourced solely to the css sheet making them instantly configurable:

Stroke and Fill in: (maybe shape-rendering)

axisElement
.selectAll('path')
.style('fill', 'none')
.style('stroke', '#222')
.style('shape-rendering', 'crispEdges');
axisElement
.selectAll('line')
.style('fill', 'none')
.style('stroke', '#222')
.style('shape-rendering', 'crispEdges');

axisElement
.selectAll('path')
.style('fill', 'none')
.style('stroke', '#222')
.style('shape-rendering', 'crispEdges');
axisElement
.selectAll('line')
.style('fill', 'none')
.style('stroke', '#222')
.style('shape-rendering', 'crispEdges');

Font in:

pc.svg = selection
.append('svg')
.attr('width', config.width)
.attr('height', config.height)
.style('font', '14px sans-serif')
.style('position', 'absolute')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant