-
-
Notifications
You must be signed in to change notification settings - Fork 73
-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properties Editor - Camera - Depth of Field Eyedropper update from Blender #4257
Labels
8 - invalid
Cannot reproduce. Or is no task to solve.
Comments
Ah, previously we had our own code to make this feature discoverable, atleast to show the tooltip. It must have been lost with a merge. I'll close, looks like you can now use it without hotkey only operations. |
Draise14
added
8 - invalid
Cannot reproduce. Or is no task to solve.
and removed
0 - task
A normal development task
Needs more information
labels
Jul 5, 2024
Okay, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Blender
Blender finally added the camera eye dropper, a bit more elegant than our one, but we probably should update.
Here is the code in
properties_data_camera.py
Details
SHA-1: e8d028b
Depthdropper should ensure that the viewport is in camera view to use
active camera position, otherwise it should still use rv3d->viewinv[3]
to ensure correct distance result.
Pull Request: https://projects.blender.org/blender/blender/pulls/121339
More Details
UI: Add eyedropper button to camera focus distance
Blender already had the ability to sample the depth with an eyedropper
and fill the focus distance (see
"ui.eyedropper_depth"
). But this featurewas fairly hidden. You had to hover over the
focal_distance
propertyin the camera data panel and then press
E
(then sample a distancein the 3D viewport).
This patch adds a
prop_data_path
property to theui.eyedropper_depth
operator to allow specifying the property that should be filled with the
depth value.
The idea for this is taken from
wm.radial_control
, which also uses thisapproach to write to a property. This allows us to add the eyedropper
as a button.
Pull Request: #121486
The text was updated successfully, but these errors were encountered: