-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to change ports #13
Comments
Is this still an issue? Or do the .env files make this a non-issue? |
The issue here is, that not every file follows the .env direction. For example, the Dockerfile relies on a static port I've entered manually. |
@devmaximilian Do you think we could make the Dockerfile parse the data we've entered on production.env? |
@Beyarz Yes, that should be possible. I think we can use ENV to accomplish this. |
@Beyarz After some further investigation, I can say that what I previously suggested won't be possible. I'd suggest that we use environment variables passed to the production image (when it is run) to set the values for the healthcheck and application. |
At the moment, if I would like to to change the port for production, I'd have to manually change the number on a few places.
This can easily be refactored to one single dependent file.
The text was updated successfully, but these errors were encountered: