Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to change ports #13

Open
Beyarz opened this issue Feb 16, 2020 · 5 comments
Open

Make it easier to change ports #13

Beyarz opened this issue Feb 16, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@Beyarz
Copy link
Owner

Beyarz commented Feb 16, 2020

At the moment, if I would like to to change the port for production, I'd have to manually change the number on a few places.

This can easily be refactored to one single dependent file.

@Beyarz Beyarz added the enhancement New feature or request label Feb 16, 2020
@devmaximilian
Copy link
Collaborator

Is this still an issue? Or do the .env files make this a non-issue?

@Beyarz
Copy link
Owner Author

Beyarz commented Feb 16, 2020

Is this still an issue? Or do the .env files make this a non-issue?

The issue here is, that not every file follows the .env direction. For example, the Dockerfile relies on a static port I've entered manually.

@Beyarz
Copy link
Owner Author

Beyarz commented Feb 16, 2020

@devmaximilian Do you think we could make the Dockerfile parse the data we've entered on production.env?

@devmaximilian
Copy link
Collaborator

@Beyarz Yes, that should be possible. I think we can use ENV to accomplish this.

@devmaximilian devmaximilian self-assigned this Feb 17, 2020
@devmaximilian
Copy link
Collaborator

@Beyarz After some further investigation, I can say that what I previously suggested won't be possible. I'd suggest that we use environment variables passed to the production image (when it is run) to set the values for the healthcheck and application.

@devmaximilian devmaximilian removed their assignment Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants