Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Proxy - Allow users to set DynamoDB URL for Key Management #1307

Closed
ishaan-jaff opened this issue Jan 3, 2024 · 8 comments
Closed
Labels
enhancement New feature or request

Comments

@ishaan-jaff
Copy link
Contributor

ishaan-jaff commented Jan 3, 2024

The Feature

User wants to do key mgmt and budget tracking, but can only use DynamoDB

Motivation, pitch

user request

Twitter / LinkedIn details

No response

@ishaan-jaff ishaan-jaff added the enhancement New feature or request label Jan 3, 2024
@ishaan-jaff
Copy link
Contributor Author

looks like we had an issue for dynamoDB: #887

doesn't seem like dynamodb would be supported by the prisma interface - prisma/prisma#1676 (comment)

@ishaan-jaff
Copy link
Contributor Author

An alternative here is using AWS RDS https://aws.amazon.com/rds/free/?loc=ft#Free_Tier

Which provides PostgreSQL on AWS

@krrishdholakia
Copy link
Contributor

User said DynamoDB is a hard requirement.

We could just use boto3 for this - https://www.honeybadger.io/blog/using-dynamodb-with-python/

Since our db client is already abstracted away -

class PrismaClient:

We could just do this ourselves

@krrishdholakia
Copy link
Contributor

Don't think we should do this ourselves. Seems like there's different edge cases here - e.g. how you set compute cost (aws charges per read/write or by compute, etc.)

Considering using this - https://github.com/pynamodb/PynamoDB

@krrishdholakia
Copy link
Contributor

I have an initial working commit - https://github.com/BerriAI/litellm/tree/litellm_dynamo_db_keys

Really concerned about the overhead of supporting 2 different db formats (nosql + sql)

@krrishdholakia
Copy link
Contributor

krrishdholakia commented Jan 9, 2024

pynamodb doesn't support async 😢 pynamodb/PynamoDB#802

exploring alternatives

@krrishdholakia
Copy link
Contributor

@krrishdholakia
Copy link
Contributor

pending work - enable spend tracking for dynamodb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants