Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add number_metabomatching_permutations as an option #3

Open
mattiat opened this issue Jul 25, 2019 · 5 comments
Open

add number_metabomatching_permutations as an option #3

mattiat opened this issue Jul 25, 2019 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mattiat
Copy link
Collaborator

mattiat commented Jul 25, 2019

In metabomodules.py “number_metabomatching_permutations” variable is hardcoded please add it to parsers’ argument as it is impossible to change it for users using the docker. Also add a warning if it is set to less than 9999 that for the filtering to be reliable this variable should be set to 9999.

@mattiat mattiat added the enhancement New feature or request label Jul 25, 2019
@mattiat
Copy link
Collaborator Author

mattiat commented Jul 25, 2019

I don't think we should allow end users to change this. Why allowing them to change it and them warning them they should not?

@mattiat mattiat added the help wanted Extra attention is needed label Jul 25, 2019
@mattiat
Copy link
Collaborator Author

mattiat commented Jul 25, 2019

@BKhalili can you explain your motivation?

@BKhalili
Copy link

Right now it is 99 in the code. I think you should allow for the change if a user wants to have a quick check. Like in our case that we want to check the code and results.

mattiat added a commit that referenced this issue Jul 25, 2019
@mattiat mattiat closed this as completed Jul 25, 2019
@mattiat mattiat removed the help wanted Extra attention is needed label Jul 25, 2019
@BKhalili
Copy link

There is an error when trying to run the docker and changing the number of permutations.
In line 176 of metabomodules.py when printing the warning str(number_metabomatching_permutations) should replace number_metabomatching_permutations.

@BKhalili BKhalili reopened this Jul 31, 2019
@mattiat
Copy link
Collaborator Author

mattiat commented Aug 1, 2019

Fixed, thanks!

@mattiat mattiat added bug Something isn't working help wanted Extra attention is needed and removed enhancement New feature or request labels Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants