Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C does not stop monet #9

Open
mattiat opened this issue Jan 9, 2020 · 5 comments
Open

Ctrl-C does not stop monet #9

mattiat opened this issue Jan 9, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mattiat
Copy link
Contributor

mattiat commented Jan 9, 2020

Launch clean up action in case monet is interrupted by keyboard

@mattiat mattiat added the enhancement New feature or request label Jan 9, 2020
@mattiat
Copy link
Contributor Author

mattiat commented Jan 17, 2020

I was going to try a simple trapping:
https://rimuhosting.com/knowledgebase/linux/misc/trapping-ctrl-c-in-bash

Unfortunately this does not work for docker: once the docker run command is invoked by MONET, control passes to docker, which cannot be killed by Ctrl-C:
https://stackoverflow.com/questions/54946227/how-to-exit-and-kill-the-running-docker-container-with-ctrlc

@mattiat
Copy link
Contributor Author

mattiat commented Jan 17, 2020

instead of trapping Ctrl-C, I added an option to kill containers the "docker way" (i.e. using docker stop).
54a4930

@mattiat
Copy link
Contributor Author

mattiat commented Jan 17, 2020

Trickier for singularity, I can't find any "stop" command.
https://stackoverflow.com/questions/59791791/stopping-a-singularity-container

@mattiat
Copy link
Contributor Author

mattiat commented Jan 21, 2020

Resorted to keeping track of monet's pid and killing that.
9ee778e

Ready for testing.

@mattiat
Copy link
Contributor Author

mattiat commented Jan 21, 2020

Joan and Sergio are going to test this.

@mattiat mattiat added the help wanted Extra attention is needed label Jan 21, 2020
@mattiat mattiat self-assigned this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant