Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R1 clustering in MONET dosent work #51

Open
Jordi-Valls opened this issue Aug 25, 2021 · 5 comments
Open

R1 clustering in MONET dosent work #51

Jordi-Valls opened this issue Aug 25, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Jordi-Valls
Copy link

Hi collegues,

sorry to open this issue, but I'm not able to execute R1 clustering mode. I tried to follow other issues that talk about "'problem too large' and I cannot understand how to solve it.... This is my output error:

R1: Running Team Causality's code from the DREAM challenge on disease module identification
[1] "/R1_code/sub-challenge1"

Attaching package: 'igraph'

The following objects are masked from 'package:stats':

decompose, spectrum

The following object is masked from 'package:base':

union

Error in asMethod(object) :
Cholmod error 'problem too large' at file ../Core/cholmod_dense.c, line 105
Calls: main ... generateFile -> as.matrix -> as.matrix.Matrix -> as -> asMethod
Execution halted

Which is similar than other issues. I execute monet by default with my network file, and the error persist.... I will appreciate a detailed steps to execute R1 correctly.

Thanks for your time

Jordi

@mattiat
Copy link
Contributor

mattiat commented Aug 31, 2021

Dear Jordi,
this issues reminds me of https://github.com/BergmannLab/MONET/issues/15
We actually have open branches where we were trying to solve this: https://github.com/BergmannLab/MONET/tree/issues_15 and https://github.com/BergmannLab/MONET/tree/issues_15_2
@WeijiaZhang24: what is the status? Can you finish this up?

@mattiat mattiat added the bug Something isn't working label Aug 31, 2021
@mattiat
Copy link
Contributor

mattiat commented Sep 3, 2021

Dear Jordi, some updates:
Weijia says: "I had a look on the problem again and believe that the cause is how the code of R1 method handles node ID inputs. The R script calls a C executive which constructs matrix from the input. If the input has large node ID, e.g., Node 99999, then matrix of 99999*99999 size will be constructed, even if the input actually only has a few nodes. If this is indeed the case, I should be able to fix it next week".
We all started new jobs and are quite busy, thank you for your patience!

Cheers, Mattia

@WeijiaZhang24
Copy link
Contributor

@mattiat I created a pull request for the fix.
@Jordi-Valls would you please confirm (after Mattia has merged the pull request) whether this solves your problem?

@mattiat
Copy link
Contributor

mattiat commented Sep 9, 2021

Merged, thank you @WeijiaZhang24 for pushing a fix and testing it.
@Jordi-Valls Please let us know if things work for you.

@Jordi-Valls
Copy link
Author

Jordi-Valls commented Sep 9, 2021

Okay @mattiat and @WeijiaZhang24 , thanks for your help, I will reinstalled MONET and I will tell you if I can run R1 properly.

Best,

Jordi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants