Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sustaining leading zero before the decimal point #664

Open
MAMPAgent opened this issue Jan 11, 2023 · 2 comments · May be fixed by #669
Open

Sustaining leading zero before the decimal point #664

MAMPAgent opened this issue Jan 11, 2023 · 2 comments · May be fixed by #669

Comments

@MAMPAgent
Copy link

Check this line in project.
The problem is formatCurrency() does not respect optionalCharacteristic option and chops off leading zero before the decimal point.

For example for this input:

numbro(-0.004).format({
    output: 'currency',
    currencySymbol: '$',
    currencyPosition: 'prefix',
    mantissa: 2,
    optionalCharacteristic: false
});

we get this output:

-$.00

but it should be:

-$0.00
@MaryamAsgarinezhad MaryamAsgarinezhad linked a pull request Jan 14, 2023 that will close this issue
Open
@myangschonfeld
Copy link

Hi @BenjaminVanRyseghem. I am having the same issue. Is there any reason why the bugfix PR is not merged in?

@BenjaminVanRyseghem
Copy link
Owner

The PR is not passing the CI, is not adding any tests, and in a general manner, does not follow the contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

This commit closes issue 664 MaryamAsgarinezhad/numbro
3 participants
@BenjaminVanRyseghem @MAMPAgent @myangschonfeld