Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: clock cultists can't wear armour robes + more clock cult related stuff #11954

Open
Geatish opened this issue Nov 28, 2024 · 2 comments · May be fixed by #11957
Open

[Bug]: clock cultists can't wear armour robes + more clock cult related stuff #11954

Geatish opened this issue Nov 28, 2024 · 2 comments · May be fixed by #11957
Assignees

Comments

@Geatish
Copy link
Contributor

Geatish commented Nov 28, 2024

BYOND Version

No response

Round Date

2024/11/28

Round ID

50803

Test merges

#9124: 'Enable serverside 515.1614' by Crossedfall at commit 1b8f225789
#10897: '[PORT] Follows up TG's atom_hud system' by EvilDragonfiend at commit 51f8edef4f

Describe the bug

Clock cultists who try and pick up their armour get chocked, even after the portal is opened.
The clock cultist hammer is able to fit inside first aid kits(maybe more weapons are able too also)
non clock cultists are able to pick up cultist weapon and use them.

What did you expect?

I expected to be able to equip the armour as a cultist.
I expected to not be able to put the hammer in a first aid kit
I expected to not be sliced down by normal crew with a cultist weapon

Reproducible steps

1: try to pick up the clock cult body armour as a cultist
2: get chocked

1: put a hammer in the first aid kit and see it fit (literally hammerspace)

1: take a clock cultist weapon from a cultist
2: use it to beat the hell out of that cultist and have no worry

@PowerfulBacon
Copy link
Member

PowerfulBacon commented Nov 29, 2024

@Tsar-Salat
image

grrr, this bug was implemented as part of a PR that's whole point was to improve unit testing

@Tsar-Salat
Copy link
Contributor

that's whole point was to improve unit testing

And it was failing because dummies couldn't equip it, which was the whole testing environment to see if a outfit worked.

I will tweak the check so both dummies and cultists can wear it, and players cannot

@Tsar-Salat Tsar-Salat linked a pull request Nov 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants