Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeSimpleSoap PHP7 Error - String special class name #79

Open
pierophp opened this issue Nov 6, 2015 · 4 comments
Open

BeSimpleSoap PHP7 Error - String special class name #79

pierophp opened this issue Nov 6, 2015 · 4 comments

Comments

@pierophp
Copy link

pierophp commented Nov 6, 2015

When try install BeSimpleSoap in PHP 7 a got this error message:

Notice: Use of undefined constant WSDL_CACHE_DISK - assumed 'WSDL_CACHE_DISK' in /var/www/inoserver/vendor/burti/besimple-soap-bundle/BeSimple/SoapBundle/DependencyInjection/BeSimpleSoapExtension.php on line 161

Fatal error: Cannot use BeSimple\SoapBundle\Util\String as String because 'String' is a special class name in /var/www/inoserver/vendor/burti/besimple-soap-bundle/BeSimple/SoapBundle/Converter/TypeRepository.php on line 16

I think is necessary change the "String" class name. Maybe to "StringHelper" or "StringUtil"

Thanks

@phpmike
Copy link

phpmike commented Feb 8, 2016

The are few classes like this to change...

@rpcjacobs
Copy link

@pierophp Maybe you made the same mistake as i had, purely because i was in a hurry.

If you found this bundle initially through google besim.pl, perhaps you used the 'requires' from the composer installation page;

{
    "require": {
        "besimple/soap":   "0.1.*@dev,
        "ass/xmlsecurity": "dev-master"
    }
}

Which might not have been intentionally, as in, requiring the old (lower) version. 0.0

If so, remove "ass/xmlsecurity": "dev-master", and change version constraint to;

{
    "require": {
        "besimple/soap":   "0.2.*@dev,
    }
}

After updating your project it auto magically supports PHP7 all of a sudden, without any change to the bundle files.

@phpmike
Copy link

phpmike commented Apr 14, 2016

I don't understand, because in 0.2.6 I see that: https://github.com/BeSimple/BeSimpleSoap/blob/0.2/src/BeSimple/SoapBundle/Util/String.php
And it's not PHP7 compatible.

@pierophp
Copy link
Author

pierophp commented May 2, 2016

Hi,

I made a simple pull request to fix the issue

#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants