Discussion: My work refactoring bash-It and possible integration paths #2178
Replies: 16 comments
-
|
As I said in #1664 (comment), I think the way forward for merging this into the mainline is by creating small PRs and make this as many incremental changes as we can |
Beta Was this translation helpful? Give feedback.
-
|
@NoahGornyI agree with the approach but I am wondering what changes/things you would like to see moving over? |
Beta Was this translation helpful? Give feedback.
-
|
Well, I guess we need to start at the lowest level... Can you walk us through the first item on your list (split core engine from components)? What does that entail? |
Beta Was this translation helpful? Give feedback.
-
|
gentle ping @ahmadassaf |
Beta Was this translation helpful? Give feedback.
-
|
@ahmadassaf, since you uploaded a new repository rather than forking on GitHub, it's kind of hard to compare your changes without specifically spending time to configure a local git repo for this purpose. That makes it harder for anyone who isn't already invested specifically in your fork to work with it. I can post instructions for re-creating your GitHub repo as a fork of this one and then I'll be happy to help bring incremental improvements upstream. Are you still interested in contributing upstream? |
Beta Was this translation helpful? Give feedback.
-
|
I am reopening this as this is an important issue! |
Beta Was this translation helpful? Give feedback.
-
|
I think the no-response bot needs some tweaking. For the moment, maybe remove the "needs response" label? |
Beta Was this translation helpful? Give feedback.
-
|
Looking at his repo, it seems like it's been untouched since he submitted this issue. |
Beta Was this translation helpful? Give feedback.
-
|
hello all! sorry for being absent! yes I am definitely keen to contribute to the upstream. I think the repo is in a pretty stable version and I have been using my fork since then. Please let me know how to move forward and am keen to kick this off again! |
Beta Was this translation helpful? Give feedback.
-
@ahmadassaf, the most helpful thing from my point of view would be to make your repo be a fork of the upstream repo. Would you be open to this if I post instructions? Short version: delete the repo from GitHub.com, fork the main repo on GitHub.com, rename on GitHub.com to match your preexisting repo (so the url is the same as it was), then force-push from your local repo. The result will be that the "new" forked repo will have exactly the code you have in there now, but GitHub will now treat it as a fork and make it really easy to compare and do pull requests and all that stuff. At that point, I'd be happy to help do the leg work of bringing in improvements piecemeal. I've accidentally started doing a lot of improvements myself so I've already got some momentum going with the workflow. Note: I'm not a member of the project, just another contributor like yourself so if @NoahGorny or @davidpfarrell or another maintainer says something else please listen to them. 😃 |
Beta Was this translation helpful? Give feedback.
-
|
The way we should merge your changes upstream should go by creating small PRs with specific commits that add specific functionality. This will require a fork, but after doing this chore and opening up PRs I will gladly take a look and try to merge them here! |
Beta Was this translation helpful? Give feedback.
-
|
alright lads! will be a festive weekend then! looking forward to it |
Beta Was this translation helpful? Give feedback.
-
|
update: I have made the fork and I am trying to wrap my head around what the hell did I do almost a year ago now! taking time but getting there |
Beta Was this translation helpful? Give feedback.
-
|
As a question before making a PR. Does it make sense to you guys to separate the main "core" of bash-it from the plugins, completions, themes, etc. @NoahGorny @gaelicWizard @nwinkler Example is in here whereas everything was moved into a components folder and will be fetched as submodules. If so, then happy to make that as PR 1 |
Beta Was this translation helpful? Give feedback.
-
I think that splitting part of the repo into a submodule will not be very helpful, as it will be harder to maintain. I personally dislike submodules anyway. I think we can incorporate your changes without actually splitting part of the repo into a submodule. Let me know what you think @ahmadassaf 😄 |
Beta Was this translation helpful? Give feedback.
-
|
I too have had the urge to do a little spring cleaning 😸 |
Beta Was this translation helpful? Give feedback.
-
I am a huge fan of bash-it, but the more I used it, the more I ran into some issues. Thats when I started to dig into the codebase, open PRs and contribute to the codebase. It is however, after digging deeper into some areas that I found myself moving lots of parts and restructuring big chunks the code. Moreover, I found various inconsistencies when it came to code style and adherence to bash best practices.
gaudi-bash is my fork with lots of opinionated changes in the code to suit my OCD-like nature. I am by no means a bash expert but I tried my best to conform to the best practices in here.
I also found lots of unused and redundant code, a huge part of that was to ensure backward compatibility with the older versions of bash-it. Sometimes, it is better to start fresh and put the past behind us!
The main changes in this repo are:
bash-it backupandbash-it restoreBeta Was this translation helpful? Give feedback.
All reactions