-
Notifications
You must be signed in to change notification settings - Fork 54
Potential missing metadata attribute for REX.W prefix and no prefix needed #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You're right, I didn't notice this before. I will need more time to think about the XML implementation. And yes, |
Idea: reuse |
It seems that because of AVX |
Related missing instructions:
|
Moved to mazegen/x86reference#15 |
There are some instructions where a rex prefix is used to change the instruction but not affect any of the operands, so one cannot use operand types like
qp
,dqp
,vqp
,ptp
, for exmaple the instructionXRSTOR64
which is encoded as such (Taken from Intel's manual):I think as far as my understanding it's doing the same operation as
XRSTOR
but saving different register data to theXSAVE AREA
so one can argue it could have it's own syntax, even tho right now the XML reference doesn't mention any of these FPU registers besides the normalST(i)
,MMX
,XMM
, etc...*There're couple more related instructions like this like
XSAVE
etc..So I'm wondering if we would like to support this different mnemonic we would need to think of a way to enforce
REX.W
prefix on a syntax element.We can't use the
pref
attribute since it only covers one prefix andREX.W
could be several, but we could makepref
either a string or a list of strings in the xml for such cases or even a new attribute. If no instructions like this exists that actually does something different besides having64
in the name of the mnemonic and just fiddling a bit different with some special registers, I think this feature is not a must.Something else that bothers me more is the disregardance of the
NP
(no prefix allowed) encoding of alot of the instructions in the manual, if a parser would want to use the XML it would assume prefixes are allowed if no indication is given. I think a proper solution to this would be to add some attribute likenp
to the syntax element.The text was updated successfully, but these errors were encountered: