Skip to content

Commit 38bcf1d

Browse files
authored
Merge pull request #445 from Bamdoliro/main
main -> develop
2 parents 9219aa2 + 780a3ef commit 38bcf1d

File tree

3 files changed

+20
-22
lines changed

3 files changed

+20
-22
lines changed

apps/admin/src/components/form/FormDetailContent/성적/교과성적/교과성적.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ const 교과성적 = ({ id }: Props) => {
2323
{achievementLevelsGroupList.map((group) => (
2424
<교과성적Item
2525
subjectName={group.subjectName}
26-
achievementLevel21={group.achievementLevels[0] || '없음'}
27-
achievementLevel22={group.achievementLevels[1] || '없음'}
28-
achievementLevel31={group.achievementLevels[2] || '없음'}
26+
achievementLevel21={group.achievementLevels[0] || '-'}
27+
achievementLevel22={group.achievementLevels[1] || '-'}
28+
achievementLevel31={group.achievementLevels[2] || '-'}
2929
/>
3030
))}
3131
</Column>

apps/user/src/components/common/Wrappers/AuthWrapper/AuthWrapper.tsx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import { ROUTES } from '@/constants/common/constant';
2-
import { 제출_마감_날짜, 제출_시작_날짜 } from '@/constants/form/constant';
32
import { useUser } from '@/hooks';
43
import { useOverlay } from '@toss/use-overlay';
5-
import dayjs from 'dayjs';
64
import { usePathname, useRouter } from 'next/navigation';
75
import { ReactNode, useEffect } from 'react';
86
import FormPeriodModal from './FormPeriodModal/FormPeriodModal';
@@ -30,23 +28,25 @@ const AuthWrapper = ({ children }: Props) => {
3028
};
3129

3230
useEffect(() => {
33-
if (NOT_LOGGEDIN_PRIVATE_PAGE.includes(pathName) && !isLoggedIn) {
34-
openRequiredLoginModal();
35-
router.push(ROUTES.MAIN);
36-
}
31+
// 로그인이 되었을때
3732
if (isLoggedIn) {
3833
if (LOGGEDIN_PRIVATE_PAGE.includes(pathName)) {
3934
openFormPeriodModal();
4035
router.push(ROUTES.MAIN);
41-
} else if (
42-
dayjs().isBefore(제출_시작_날짜) ||
43-
(dayjs().isAfter(제출_마감_날짜) && process.env.NODE_ENV !== 'development')
44-
) {
45-
if (pathName === ROUTES.FORM) {
46-
router.push(ROUTES.MAIN);
47-
} else if (pathName === ROUTES.FIRST_RESULT || pathName === ROUTES.FINAL_RESULT) {
48-
router.push(ROUTES.MAIN);
49-
}
36+
}
37+
// else if (dayjs().isBefore(제출_시작_날짜) || dayjs().isAfter(제출_마감_날짜)) {
38+
// if (pathName === ROUTES.FORM) {
39+
// router.push(ROUTES.MAIN);
40+
// } else if (pathName === ROUTES.FIRST_RESULT || pathName === ROUTES.FINAL_RESULT) {
41+
// router.push(ROUTES.MAIN);
42+
// }
43+
// }
44+
}
45+
// 로그인이 되지 않았을때
46+
else {
47+
if (NOT_LOGGEDIN_PRIVATE_PAGE.includes(pathName)) {
48+
openRequiredLoginModal();
49+
router.push(ROUTES.MAIN);
5050
}
5151
}
5252
}, [isLoggedIn, pathName]);

apps/user/src/components/form/Calculators/ScoreCalculator/GradeCalculator/GradeCalculator.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ const GradeCalculator = () => {
3535
id={id}
3636
key={`subject ${id}`}
3737
achievementLevels={
38-
isSpecialSubject
39-
? ['없음', 'A', 'B', 'C']
40-
: ['없음', 'A', 'B', 'C', 'D', 'E']
38+
isSpecialSubject ? ['-', 'A', 'B', 'C'] : ['-', 'A', 'B', 'C', 'D', 'E']
4139
}
4240
/>
4341
);
@@ -47,7 +45,7 @@ const GradeCalculator = () => {
4745
<NewGradeCalculatorItem
4846
id={id}
4947
key={`new-subject ${id}`}
50-
achievementLevels={['없음', 'A', 'B', 'C', 'D', 'E']}
48+
achievementLevels={['-', 'A', 'B', 'C', 'D', 'E']}
5149
/>
5250
))}
5351
<GradeCalculatorFooter>

0 commit comments

Comments
 (0)