Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser extensions will not open MPV on PopOS. #27

Open
2 tasks done
robbhimself opened this issue Mar 5, 2024 · 3 comments
Open
2 tasks done

Browser extensions will not open MPV on PopOS. #27

robbhimself opened this issue Mar 5, 2024 · 3 comments
Assignees
Labels
bug Something isn't working player issue Something is wrong interfacing with a player

Comments

@robbhimself
Copy link

robbhimself commented Mar 5, 2024

Bug Description

On PopOS with both chrome and firefox, the extension will not open mpv. The xdg-open dialog box appears and you click "open in open-in-mpv" and nothing happens.

mpv works fine from terminal and playing youtube videos with mpv+yt-dlp works fine.

How to Reproduce

Steps to reproduce the behavior:

  1. Go to 'youtube'
  2. Click on 'open in mpv from the extension menu or the right click menu
  3. Click "open in open-in-mpv" from the xdg-open dialog
  4. See 'nothing happens :('

Expected Behavior

Open mpv when you click "open in open-in-mpv" from the xdg-open dialog

Version

2.2.0

Configuration

players:
  mpv:
    name: mpv
    executable: mpv
    fullscreen: "--fs"
    pip: "--ontop --no-border --autofit=384x216 --geometry=98\\%:98\\%"
    enqueue: ""
    new_window: ""
    needs_ipc: true
    flag_overrides: {}

Relevant log output (optional)

ive tried the precompiled binaries and compiled from git, the install-protocol.sh copies files to the right paths. Just nothing happens when the browser calls mpv.

What browsers are you seeing the problem on? (optional)

Firefox-based (Librewolf, Iceraven, etc.), Chromium-based (Brave, Chrome, etc.)

Checklist:

  • I have checked for existing issues that describe my problem prior to opening this one.
  • I understand that improperly formatted bug reports may be closed without explanation.
@robbhimself robbhimself added the bug Something isn't working label Mar 5, 2024
@robbhimself
Copy link
Author

seems to work fine if mpv is already open, but it will not launch mpv

@Baldomo Baldomo added the player issue Something is wrong interfacing with a player label Mar 7, 2024
@Baldomo Baldomo self-assigned this Mar 7, 2024
@Baldomo
Copy link
Owner

Baldomo commented Mar 7, 2024

Thank you for the bug report. It makes sense that everything works when mpv is open, since the binary sends commands through the player's IPC interface. I will look into why the player isn't launched.

@Baldomo
Copy link
Owner

Baldomo commented Dec 26, 2024

Please test the latest version of both the extension and binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working player issue Something is wrong interfacing with a player
Projects
None yet
Development

No branches or pull requests

2 participants