Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with SmartFindTarget when all wheels are broken #44

Open
BahamutoD opened this issue Apr 18, 2016 · 0 comments
Open

Issue with SmartFindTarget when all wheels are broken #44

BahamutoD opened this issue Apr 18, 2016 · 0 comments

Comments

@BahamutoD
Copy link
Owner

BahamutoD commented Apr 18, 2016

This one puzzles me. I noticed that a patriot launcher vessel wasn't firing at me, and checked the log to find an NRE in SmartFindTarget(). All of the wheels on the vessel were broken, but it was landed. I EVA'd a kerbal to repair one of the wheels, and the issue was gone. My first instinct was that there's a bug in the new wheel code that would cause a vessel to be not LandedOrSplashed if only broken wheels were touching the ground, causing the guard code to NRE when trying to access the AI Pilot here: https://github.com/BahamutoD/BDArmory/blob/master/BahaTurret/MissileFire.cs#L3221.
However, I did some debug, and the vessel indeed was flagged as landed, even with the broken wheels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant