Merge pull request #100 from Backblaze/go-vet

Use go vet for linting

Author: mlech-reef

.gitignore

@@ -37,7 +37,6 @@ website/vendor
 
 # Go
 .go-version
-pkged.go
 
 # Provider binary
 /terraform-provider-b2

CHANGELOG.md

@@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Infrastructure
 * Upgrade pyinstaller to 6.11.1
+* Use `go vet` for linting
 
 ### Fixed
 * Fix an issue with missing `content_md5` in case the file has been uploaded as a large file

GNUmakefile

@@ -34,8 +34,10 @@ format: _pybindings
 	@terraform fmt -recursive ./examples/
 
 lint: _pybindings
-	@python scripts/check-gofmt.py '**/*.go' pkged.go
-	@python scripts/check-headers.py '**/*.go' pkged.go
+	@python scripts/check-gofmt.py '**/*.go'
+	@python scripts/check-headers.py '**/*.go'
+	@test -f b2/py-terraform-provider-b2 || touch b2/py-terraform-provider-b2 # required by go:embed in bindings.go
+	@go vet ./...
 
 testacc: _pybindings
 	@cp python-bindings/dist/py-terraform-provider-b2 b2/

b2/client.go

@@ -73,10 +73,11 @@ func (c Client) apply(ctx context.Context, name string, op string, input map[str
 	if err != nil {
 		if exitErr, ok := err.(*exec.ExitError); ok {
 			if exitErr.Stderr != nil && len(exitErr.Stderr) > 0 {
+				err := fmt.Errorf("%s", string(exitErr.Stderr))
 				tflog.Error(ctx, "Error in pybindings", map[string]interface{}{
-					"stderr": fmt.Errorf(string(exitErr.Stderr)),
+					"stderr": err,
 				})
-				return nil, fmt.Errorf(string(exitErr.Stderr))
+				return nil, err
 			}
 			return nil, fmt.Errorf("failed to execute")
 		} else {
@@ -118,6 +119,11 @@ func (c Client) apply(ctx context.Context, name string, op string, input map[str
 }
 
 func (c Client) populate(ctx context.Context, name string, op string, output map[string]interface{}, d *schema.ResourceData) error {
+	tflog.Info(ctx, "Populating data from pybindings", map[string]interface{}{
+		"name": name,
+		"op":   op,
+	})
+
 	resourceName := "b2_" + name
 	var schemaList []string
 	if op == DATA_SOURCE_READ {