Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PyTest in setup.py with make prepare like in Toil #358

Open
hannes-ucsc opened this issue Jul 15, 2016 · 2 comments
Open

Replace PyTest in setup.py with make prepare like in Toil #358

hannes-ucsc opened this issue Jul 15, 2016 · 2 comments

Comments

@hannes-ucsc
Copy link
Contributor

hannes-ucsc commented Jul 15, 2016

The goal was to have setup.py test install the test dependencies. Even though the goal is laudable, in practice this makes using IDEs harder (as the test dependencies are only installed for the duration of a test run) and incomplete since most of the time there are other build requirements like Sphinx that aren't covered by this.

Copy the make prepare approach from Toil and remove PyTest and tests_require from setup.py. Invoke tests directly via py.test.

@jvivian
Copy link
Collaborator

jvivian commented Jul 15, 2016

End of your message got cut off.

@hannes-ucsc
Copy link
Contributor Author

Fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants