New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check monitoring feature datasource-id before attempting to get timeseries data #21

Open

vchendrix opened this issue Dec 10, 2020 · 0 comments

Labels

Contributor

vchendrix commented Dec 10, 2020

(NOT SURE if this is the write repo)

When looking only for East River data, there is an attempt to get data from USGS.

E.g., call: http://127.0.0.1:8000/measurement_tvp_timeseries/?monitoring_features=ER-Marmot&observed_property_variables=RDC&start_date=2015-01-01&end_date=2015-02-01&aggregation_duration=DAY

Erroneous calls to USGS -- note no "sites" value
https://waterservices.usgs.gov/nwis/site/?sites=
https://waterservices.usgs.gov/nwis/dv?startDT=2015-01-01&endDT=2015-02-01&parameterCd=00060&statCd=00003&sites=&format=json

An attempt to get USGS data should not even be attempted. Check the monitoring feature datasource ID.

vchendrix added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment